Add center filter #179
Merged
Add center filter #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 88.77% 88.79% +0.01%
==========================================
Files 69 69
Lines 8715 8730 +15
==========================================
+ Hits 7737 7752 +15
Misses 978 978
Continue to review full report at Codecov.
|
flexferrum
reviewed
Nov 2, 2019
| case CenterMode: | ||
| result = ApplyStringConverter(baseVal, [this, &context](auto srcStr) -> TargetString { | ||
| auto width = ConvertToInt(this->GetArgumentValue("width", context)); | ||
| auto str = sv_to_string(srcStr); |
There was a problem hiding this comment.
I think, it should be additional trimming added at this point. Now you doesn't count the spaces which already present at the beginning or at the end of the string,
There was a problem hiding this comment.
Are you sure about that?
I tested this and it seems that it is not trimming those whitespaces:
from jinja2 import Environment
HTML = """
{{ 'x' | center(width=5) }}
{{ ' x' | center(width=5) }}
"""
def print_html_doc():
print (Environment().from_string(HTML).render())
print_html_doc()There was a problem hiding this comment.
Ok. You're right. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemention of the center filter #171