Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config option to check remote URLs for blacklisted keywords (rebased, needs testing) #41

Merged
merged 6 commits into from
May 14, 2024
Merged

Config option to check remote URLs for blacklisted keywords (rebased, needs testing) #41

merged 6 commits into from
May 14, 2024

Conversation

Lamby777
Copy link

@Lamby777 Lamby777 mentioned this pull request Apr 10, 2024
Closed
@jiriks74 jiriks74 self-assigned this Apr 10, 2024
@jiriks74
Copy link
Owner

Well sadly I am not able to push changes - Github is weird.

But formatting using stylua . should be enough to get rid of the formatting issues. If you look at the output of LuaCheck there's some extra argument that is not needed so just get rid of it.

I tried to make these changes myself for half an hour but it seems like Github won't let me access that branch for whatever reason.

@jiriks74
Copy link
Owner

Ok. I, somehow, managed to modify it manually through Github UI. Doing it through git is broken...

@jiriks74
Copy link
Owner

I have no idea what the problem with LuaCheck is

@jiriks74
Copy link
Owner

Turns out that LuaCheck was right and I just don't know Lua well

@jiriks74
Copy link
Owner

Could you please test this now that the PR is up to date and passing? @Lamby777

@jiriks74
Copy link
Owner

jiriks74 commented Apr 11, 2024 •
edited
Loading

For tracking with OpenProject:

[48] Config option to check git remote URLs for blacklisted keywords
https://openproject.stefka.eu/work_packages/48

@Lamby777
Copy link
Author

Could you please test this now that the PR is up to date and passing? @Lamby777

Sure, next time I get on the other laptop

@Lamby777
Copy link
Author

Works fine. Added Lamby777 to the blacklist and it wouldn't show the presence when I opened my game, and then I opened a different project under my org and it showed up.

Off-topic, but you might want to know: the discord application's name is presence.nvim, where the original is Neovim. It looks kinda off seeing the game called presence.nvim in the profile instead of Neovim. Easily solved by using the upstream repo's app ID listed in the readme but yea.

@Lamby777 Lamby777 marked this pull request as ready for review April 13, 2024 03:14
@jiriks74
Copy link
Owner

@Lamby777 I named the application in Discord's developer portal as presence.nvim and didn't realize that it would name it like that in Rich presence. It's fixed now.

@jiriks74
Copy link
Owner

Also AFAIK this is ready to be merged. I'll test it on the weekend myself to be sure and I'll merge it. Feel free to have any input.

@jiriks74 jiriks74 added the enhancement New feature or request label Apr 17, 2024
@Lamby777
Copy link
Author

sounds good

Feel free to have any input.

The input in question:
:3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3 :3

@jiriks74
Copy link
Owner

I'm sorry for taking longer. I'm finally, hopefully, figuring out what's wrong with my dGPU and I have some school to deal with. I'll do my best to test it before I send the laptop for, another, RMA.

@jiriks74
Copy link
Owner

Hey there. Sorry, life's been harder than I anticipated. Everything looks fine so I'll merge it.

@jiriks74 jiriks74 merged commit 883347d into jiriks74:main May 14, 2024
4 checks passed
@Lamby777
Copy link
Author

no worries, I was loading this branch of the plugin anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jiriks74 jiriks74

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lamby777 @jiriks74