Use BundleAccountLocker when handling tip txs #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalu
force-pushed
the
lb/maybe_consensus_fix
branch
from
3602c0b to
639798b
Compare
segfaultdoc
reviewed
Sep 20, 2022
core/src/bundle_account_locker.rs
Outdated
| read_locks: HashMap<Pubkey, u64>, | ||
| write_locks: HashMap<Pubkey, u64>, | ||
| ) { | ||
| let mut read_locks_l = self.read_locks.lock().unwrap(); | ||
| let mut write_locks_l = self.write_locks.lock().unwrap(); | ||
| let read_locks_l = &mut self.read_locks; |
segfaultdoc
reviewed
Sep 20, 2022
core/src/bundle_stage.rs
Outdated
| working_bank: bank, .. | ||
| } = bank_start; | ||
|
|
||
| ) -> BundleExecutionResult<Vec<SanitizedTransaction>> { |
There was a problem hiding this comment.
why do we need to wrap the return in BundleExecutionResult?
There was a problem hiding this comment.
get_configured_tip_receiver can return err
There was a problem hiding this comment.
actually brings up another bug here that i introduced, will fix
There was a problem hiding this comment.
the name's just confusing since no txs are really being executed here
segfaultdoc
reviewed
Sep 20, 2022
segfaultdoc
approved these changes
Sep 20, 2022
buffalu
commented
Sep 22, 2022
| &read_locks, | ||
| &write_locks, | ||
| ); | ||
| let batch = { |
buffalu
commented
Sep 22, 2022
buffalu
commented
Sep 22, 2022
segfaultdoc
reviewed
Sep 22, 2022
segfaultdoc
reviewed
Sep 22, 2022
segfaultdoc
reviewed
Sep 22, 2022
buffalu
added a commit
that referenced
this pull request
Sep 22, 2022
buffalu
pushed a commit
that referenced
this pull request
Mar 14, 2024
…133) (#143) * add precompile signature metrics to cost tracker (#133) (cherry picked from commit 9770cd9) * merge fix * fmt --------- Co-authored-by: Tao Zhu <[email protected]> Co-authored-by: Tao Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We weren't previously locking any accounts related to processing tip receiver transactions. The consensus issues we've been seeing are what I believe to be a race condition between voting transactions that use the identity account and transactions involved with changing the tip receiver.
Summary of Changes
Use BundleAccountLocker to make sure all accounts involved in a tip transaction are locked
TODO