Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): hermes and react native are synced #15353

Merged

Conversation

Calinteodor
Copy link
Contributor

No description provided.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was succesfully scanned and it was determined that it does not contain any changes that present immediate security concerns. If you would still like for it to be reviewed by an expert from our reviewer community, you can submit it manually via the HackerOne PullRequest dashboard

@Calinteodor Calinteodor merged commit c0541c8 into jitsi:master Dec 3, 2024
11 checks passed
keremoge pushed a commit to keremoge/jitsi-meet that referenced this pull request Jan 8, 2025
Version wise, Hermes and React Native are synced.
@mesutaltuncu
Copy link

Is there a Beta version available on the Google Play Store with Hermes enabled?

@saghul
Copy link
Member

saghul commented Jan 30, 2025

Yes, the current beta in the Play Store uses Hermes indeed.

@mesutaltuncu
Copy link

The splash time duration seems to have increased during the beta period. In the non-beta version, I observed a shorter splash time duration.

@saghul
Copy link
Member

saghul commented Jan 30, 2025

That's what we observed back in the day wqhen we 1st tried Hermes too. Which is surprising, because it's supposed to provide better loading times 🤷

That said, the reason for migrating is also that JSC on Android is not getting any updates and won't support 16KB memory page sizes, as required by Android 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants