Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Bug: Hide "Mute all" option when all participants are moderators #15461

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Fixed Bug: Hide "Mute all" option when all participants are moderators #15461

merged 3 commits into from
Jan 9, 2025

Conversation

arorabhavik1001
Copy link
Contributor

Fixes bug discussed in #15460

  • Resolved the bug where the "Mute all" button was incorrectly visible even when all participants were moderators, as moderators are always allowed to unmute.
  • Implemented logic to get the number of non moderator participants and use that as additional condition in isMuteAllVisible method, which determins the visibility of the button.
    • Added getNumberOfNonModeratorParticipants method to facilitate the same.

PFA, the video for reference.

Recording.2025-01-09.033300.1.mp4

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@arorabhavik1001
Copy link
Contributor Author

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Signed.

@damencho
Copy link
Member

damencho commented Jan 9, 2025

Well, mute all is fine to be there. It is just in the mute all dialog the toggle switch that needs to be hidden.
A moderator is ok to be able to mute another moderator.

@damencho
Copy link
Member

damencho commented Jan 9, 2025

There is already utility methods to check are all moderators, use those and don't introduce new one.

jitsi-meet/react/features/participants-pane/components/web/FooterContextMenu.tsx

Line 91 in 1376f59

const allModerators = useSelector(isEveryoneModerator);

@damencho damencho added the info:cla-signed The CLA has been signed label Jan 9, 2025
@arorabhavik1001
Copy link
Contributor Author

Ok, got it.

@arorabhavik1001
Copy link
Contributor Author

arorabhavik1001 commented Jan 9, 2025 •
edited
Loading

Hi @damencho, I've updated the changes. Now the conditional is set on the toggle in the dialog box, and i've used the existing utility method isEveryoneModerator which i'm passing to the dialog box with its other props. Didn't notice the existing method earlier :-)

Also, i've undone the previous change

@arorabhavik1001
Copy link
Contributor Author

hi @saghul, i've fixed the eslint warnings & errors that occured in last test and updated the code.

@damencho
Copy link
Member

damencho commented Jan 9, 2025

Jenkins, test this please.

@arorabhavik1001
Copy link
Contributor Author

arorabhavik1001 commented Jan 9, 2025 •
edited
Loading

image

I don't think this error should be related to our change.

@damencho
Copy link
Member

damencho commented Jan 9, 2025

Yep, I'm seeing this lately. We are looking into it.

@arorabhavik1001
Copy link
Contributor Author

arorabhavik1001 commented Jan 9, 2025 •
edited
Loading

Yep, I'm seeing this lately. We are looking into it.

Sure. I can help along, if u want

@damencho damencho merged commit b71b4c8 into jitsi:master Jan 9, 2025
9 of 10 checks passed
wilsonfurtado2000 added a commit to wilsonfurtado2000/jitsi-meet that referenced this pull request Jan 11, 2025
@wilsonfurtado2000
lint fix
a46f620 
lint fix

lint fix

lint fix

refactor

lint fix

modified elide logic

changed words

lint fix

lint fix

lint fix

fix(polls) improve resilience to bogus data

feat(tests): Adds self view, display name and end conference tests. (jitsi#15432)

* feat(tests): Use shorter display names for screenshots.

* feat(tests): Adds self view tests.

* feat(tests): Adds display name test.

* feat(tests): Adds end conference test.

fix(configWhitelist): Remove some props.

chore(deps) lib-jitsi-meet@latest

jitsi/lib-jitsi-meet@v1890.0.0+144b0cab...v1893.0.0+496b64a7

fix(connection): Adds default tenant value on error.

Avoids undefined error.

feat(customParticipantButton): metrics

fix(lang) fix typo in unsecure room name warning (jitsi#15468)

fix(video-menu): Hide "Mute all" option when all participants are moderators (jitsi#15461)

* Fixed exception for visibility state of mute all button

* Updated changes as per review: shifted conditional to the toggle

* chore: fix eslint warnings and errors

---------

Co-authored-by: Bhavik Arora <arorabhavik1001>

fix(readme): Fixes badge icon and f-droid link.

Fixes jitsi#15464
Fixes jitsi#15465

chore(deps) lib-jitsi-meet@latest

jitsi/lib-jitsi-meet@v1893.0.0+496b64a7...v1895.0.0+7de7d9aa

fix(readme): Fixes badge icon.

Fixes jitsi#15464

lang: Update main-zhCN.json (jitsi#15426)

main-zhCN.json
line 413 missing:
"sessTerminatedReason": "会议已经结束",

feat(tests): Adds desktop sharing test.

feat(tests): Adds dial-in test. (jitsi#15470)

* feat(tests): Adds dial-in test.

* feat(tests): Adds fake dial-in test.

* squash: switch to performance.now().

fix(polls) limit maximum amount of answers

chore(helpers) drop custom createDeferred() for Promise.withResolvers()

chore(deps) update eslint

Required for compatibility with new TypeScript plugins.

fix(lint) tame linter

feat(tests): Adds follow-me and invite dialog test. (jitsi#15476)

* feat(tests): Adds follow-me test.

* feat(tests): Adds invite dialog test.

* squash: fix lint.

fix(configWhitelist): Add p2p.mobileScreenshareCodec

refined logic

remove tooltip

cleaup

Update Notification.tsx

lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
info:cla-signed The CLA has been signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arorabhavik1001 @jitsi-jenkins @damencho @saghul