-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chat) add support for sending and receiving reactions #2553
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ea87710
Build XML for sendReaction
he-patrick cbf2b6a
Create sendReaction test
he-patrick bdefd84
Create reaction event and listener
he-patrick 8d5fa22
Fix variable naming
he-patrick 1d8e794
Merge branch 'jitsi:master' into master
he-patrick 6d0fc6f
Merge branch 'jitsi:master' into master
he-patrick b9864e7
Fix reaction handling
he-patrick a5842cf
feat(JitsiConference) emit PARTICIPANT_KICKED also for the kicker
saghul f38bdab
fix(chat) add messageId to message events
he-patrick 8d2ec78
ref(QualityController) Add recovery mechanism and adjust the resoluti…
jallamsetty1 f2d69be
feat(statistics) remove AudioOutputProblemDetector
saghul 97489fc
fix(ICE): treat completed as connected
paweldomas 737d472
Update
he-patrick bb3b02d
Fix parameters
he-patrick c9aadc3
Fix definitions
he-patrick 201b49e
Fix linting errors
he-patrick f09c4d3
Update description
he-patrick d66de12
Remove extra space
he-patrick 98a8c57
Update description
he-patrick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I remove receiverId since the reactions that are attached to private messages will not be visible to others anyways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, because we want the sender to decide to whom a reaction should be sent.