Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subject): Avoids setting subject if already set. #2615

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

damencho
Copy link
Member

No description provided.

@@ -1014,6 +1014,12 @@ export default class ChatRoom extends Listenable {
* @param subject
*/
setSubject(subject) {
if ((subject || subject === '')
Copy link
Member

@hristoterezov hristoterezov Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering shouldn't we handle the cases when subject is undefined?

I guess we would at least want to still compare if the old value was undefined to not send an xmpp stanza.

Copy link
Member

@hristoterezov hristoterezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment!

@damencho damencho force-pushed the skip-setting-subject branch from ee1308e to 2255d3c Compare January 13, 2025 22:09
@damencho damencho force-pushed the skip-setting-subject branch from 2255d3c to 1f59d83 Compare January 13, 2025 22:30
@damencho damencho merged commit 7a15afa into master Jan 13, 2025
2 checks passed
@damencho damencho deleted the skip-setting-subject branch January 13, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants