fix(codec) Debounce the call that calc codec intersection set. #2622
Conversation
Calculate codec intersection set only once per second even when there is a burst of joins/leaves. Also, check for current codec before chaining a codec change operation when codec selection API is used.
| @@ -159,6 +161,26 @@ export class QualityController { | |||
| (tpc: TraceablePeerConnection, stats: Map<number, IOutboundRtpStats>) => this._processOutboundRtpStats(tpc, stats)); | |||
| } | |||
|
|
|||
| /** | |||
| * Creates a debounced function that delays the execution of the provided function until after the specified delay | |||
There was a problem hiding this comment.
Isn't this basically lodash's throtlle? https://lodash.com/docs/4.17.15#throttle
There was a problem hiding this comment.
Wait, I see you imported it but then didn't use it?
There was a problem hiding this comment.
Oh yes, I was testing with lodash throttle with both the leading and trailing options set to true and ran into this limitation - If leading and trailing options are true, func is invoked on the trailing edge of the timeout only if the throttled function is invoked more than once during the wait timeout.
I can go back and test lodash throttle with only the trailing option set to true and I believe the end result will be the same. Will update this.
There was a problem hiding this comment.
Actually when I pass { leading: false, trailing: true } to lodash's throttle, my testcases fail, its missing some of the calls when we expect them.
There was a problem hiding this comment.
We are waiting for 1000 and advancing by 1000 I bet there are shenanigans there? Perhaps we should test by waiting a bit longer?
There was a problem hiding this comment.
I got the same results when I had the timer set to 1200 ms. I remember this being the case when we initially discussed about debouncing this call and my unit tests for testing lodash's throttle had also failed.
Calculate codec intersection set only once per second even when there is a burst of joins/leaves. Also, check for current codec before chaining a codec change operation when codec selection API is used.