feat: Updates userRegion from backend. #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JitsiConference.js
Outdated
| @@ -560,6 +560,8 @@ JitsiConference.prototype._init = function(options = {}) { | |||
| // creates dominant speaker detection that works only in p2p mode | |||
| this.p2pDominantSpeakerDetection = new P2PDominantSpeakerDetection(this); | |||
|
|
|||
| // We keep this for some time, till all backends are updated to use | |||
There was a problem hiding this comment.
Should we rephrase this to the following so that it grabs attention?
TODO: Drop this after the change to use the region from the http requests to prosody is propagated to all the deployments in production.
jallamsetty1
approved these changes
Jan 27, 2025
saghul
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.