Skip to content

Commit

Permalink
config-schema.json: fixup to default-command
Browse files Browse the repository at this point in the history
Before this commit, both VS Code's "Even better TOML" and `taplo`
reported an error saying `["status","--no-pager"] is not of type
"string"` for

```toml 
"$schema" = "https://jj-vcs.github.io/jj/latest/config-schema.json"
ui.default-command = ["status", "--no-pager"]
``` 

I believe the schema was either invalid or just ignored `oneOf` because
it was trivially satisfied whenever the `type` restriction was
satisfied.
  • Loading branch information
ilyagr committed Jan 26, 2025
1 parent e299931 commit 332b8d7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cli/src/config-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
"default": false
},
"default-command": {
"type": "string",
"description": "Default command to run when no explicit command is given",
"default": "log",
"oneOf": [
Expand Down

0 comments on commit 332b8d7

Please sign in to comment.