Skip to content

Commit

Permalink
cli: remove deprecated --allow-large-revsets flag at all
Browse files Browse the repository at this point in the history
It's been deprecated since v0.9.0 (2023-09-06). This patch doesn't add
changelog entry because the use of --allow-large-revsets was hard error.
  • Loading branch information
yuja committed Jul 3, 2024
1 parent ca4eb60 commit 455daa4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
9 changes: 0 additions & 9 deletions cli/src/commands/new.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ pub(crate) struct NewArgs {
/// The change description to use
#[arg(long = "message", short, value_name = "MESSAGE")]
message_paragraphs: Vec<String>,
/// Deprecated. Please prefix the revset with `all:` instead.
#[arg(long, short = 'L', hide = true)]
allow_large_revsets: bool,
/// Do not edit the newly created change
#[arg(long, conflicts_with = "_edit")]
no_edit: bool,
Expand Down Expand Up @@ -84,12 +81,6 @@ pub(crate) fn cmd_new(
command: &CommandHelper,
args: &NewArgs,
) -> Result<(), CommandError> {
if args.allow_large_revsets {
return Err(user_error(
"--allow-large-revsets has been deprecated.
Please use `jj new 'all:x|y'` instead of `jj new --allow-large-revsets x y`.",
));
}
let mut workspace_command = command.workspace_helper(ui)?;

let parent_commits;
Expand Down
11 changes: 0 additions & 11 deletions cli/src/commands/rebase.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,6 @@ pub(crate) struct RebaseArgs {
/// parents.
#[arg(long, conflicts_with = "revisions")]
skip_empty: bool,

/// Deprecated. Please prefix the revset with `all:` instead.
#[arg(long, short = 'L', hide = true)]
allow_large_revsets: bool,
}

#[instrument(skip_all)]
Expand All @@ -206,13 +202,6 @@ pub(crate) fn cmd_rebase(
command: &CommandHelper,
args: &RebaseArgs,
) -> Result<(), CommandError> {
if args.allow_large_revsets {
return Err(user_error(
"--allow-large-revsets has been deprecated.
Please use `jj rebase -d 'all:x|y'` instead of `jj rebase --allow-large-revsets -d x -d y`.",
));
}

let rebase_options = RebaseOptions {
empty: match args.skip_empty {
true => EmptyBehaviour::AbandonNewlyEmpty,
Expand Down

0 comments on commit 455daa4

Please sign in to comment.