Rewrite rebasing in jj split using transform_descendants()
#3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emesterhazy
force-pushed
the
push-stnynwusvolv
branch
from
356c307 to
6da4e91
Compare
martinvonz
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Thanks! I'm happy to see rebase_descendants() made private again. That will make it easier for @bnjmnt4n to clean that up later.
I'm approving this because it seems clearly not specific to google, but please give non-googlers a chance to review.
emesterhazy
added a commit
that referenced
this pull request
Apr 20, 2024
This would have caught a bug in #3550 that otherwise might have slipped through.
emesterhazy
force-pushed
the
push-stnynwusvolv
branch
from
6da4e91 to
67ab40b
Compare
emesterhazy
commented
Apr 21, 2024
emesterhazy
force-pushed
the
push-stnynwusvolv
branch
from
67ab40b to
5337c47
Compare
This would have caught a bug in #3550 that otherwise might have slipped through.
emesterhazy
force-pushed
the
push-stnynwusvolv
branch
from
5337c47 to
e61d73f
Compare
This is following on the rewrite for `parallelize`. - #3521 Since rebase_descendants from rebase.rs is no longer used outside of that file, it can be made private again.
emesterhazy
force-pushed
the
push-stnynwusvolv
branch
from
e61d73f to
dd643c9
Compare
yuja
approved these changes
Apr 21, 2024
|
Thanks for taking a look Yuya. I'll merge this now. |
emesterhazy
added a commit
that referenced
this pull request
Apr 21, 2024
This would have caught a bug in #3550 that otherwise might have slipped through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is following on the rewrite for
parallelize.transform_descendants(), rewritejj parallelize#3521Since rebase_descendants from rebase.rs is no longer used outside of that file, it can be made private again.