rewrite: move_commits: add MoveCommitsTarget enum to specify roots or commits to move
#4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjmnt4n
force-pushed
the
bnjmnt4n/push-zlrppuytmrxs
branch
from
913c56a to
0a83d6a
Compare
4 tasks
bnjmnt4n
force-pushed
the
bnjmnt4n/push-zlrppuytmrxs
branch
from
0a83d6a to
6a55e1e
Compare
bnjmnt4n
force-pushed
the
bnjmnt4n/push-zlrppuytmrxs
branch
3 times, most recently
from
e11021b to
45cceab
Compare
bnjmnt4n
force-pushed
the
bnjmnt4n/push-zlrppuytmrxs
branch
from
45cceab to
1782649
Compare
|
@yuja @samueltardieu I've updated some of the function names and made the suggested tweaks. Do you think there's anything else which should be changed? |
yuja
approved these changes
Oct 22, 2024
…or commits to move This also allows some minor optimizations to be performed, such as avoiding recomputation of the connected target set when `MoveCommitsTarget::Roots` is used since the connected target set is identical to the target set (all descendants of the roots).
bnjmnt4n
force-pushed
the
bnjmnt4n/push-zlrppuytmrxs
branch
from
1782649 to
ead1802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows some minor optimizations to be performed, such as avoiding recomputation of the connected target set when
MoveCommitsTarget::Rootsis used since the connected target set is identical to the target set (all descendants of the roots).Checklist
If applicable:
CHANGELOG.md