Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add initial GOVERNANCE.md #5040

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Dec 6, 2024

After lots of discussion, we've finally achieved a draft of the governance document!

This is a draft, as it is fundamentally incomplete; that will require the election of the initial set of 5 Jujutsu Maintainers, after an open self-nomination period! Stay tuned for more on that.


This is the result of a lot of back and forth, the weekly efforts of the governance working group, currently consisting of:

  • Martin von Zweigbergk (martinvonz)
  • Waleed Khan (arxanas)
  • Emily Shaffer (nasamuffin)
  • Austin Seipp (thoughtpolice; yours truly)

Many thanks as well to emeritus member Khionu Sybiern, who helped kickstart this whole process.

@thoughtpolice thoughtpolice self-assigned this Dec 6, 2024
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
@PhilipMetzger
Copy link
Contributor

You forgot to add it to the website and renaming the old temporary governance.

Copy link
Contributor

@nasamuffin nasamuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a solid start, and I'm glad to see other community members chiming in. Should we push this review more in the Discord starting next week, when people are likely to be back from vacationing?

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
@thoughtpolice thoughtpolice force-pushed the aseipp/push-xsqsllnzzswk branch from d8a09f7 to e71ca29 Compare January 2, 2025 18:56
@thoughtpolice thoughtpolice marked this pull request as ready for review January 2, 2025 18:57
@nasamuffin
Copy link
Contributor

New update looks good to me, for starters. Only thing I might add is - what's the process for modifying governance.md? Do changes need to go to a maintainer vote through the regular process? Since this is a good start but fairly bare-bones, I think it's worth outlining how we intend to update it later if/when we need to.

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
@thoughtpolice thoughtpolice force-pushed the aseipp/push-xsqsllnzzswk branch 2 times, most recently from e9a2443 to 52fbe51 Compare January 3, 2025 03:01
@@ -131,7 +131,7 @@ nav:
- 'Code of conduct': 'code-of-conduct.md'
- 'Design Docs': 'design_docs.md'
- 'Design Doc Blueprint': 'design_doc_blueprint.md'
- 'Temporary Voting for Governance': 'governance/old-temporary-voting.md'
- 'Governance': 'governance/GOVERNANCE.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Preserve the old link, as its still somewhat useful.

@arxanas
Copy link
Contributor

arxanas commented Jan 3, 2025

Only thing I might add is - what's the process for modifying governance.md? Do changes need to go to a maintainer vote through the regular process?

I think basically we expected to use the Decision-Making process for modifying governance.md.

Just shuffling stuff in the cellar.

Signed-off-by: Austin Seipp <[email protected]>
This is the result of a lot of back and forth, the weekly efforts of the
governance working group, consisting of:

- Martin von Zweigbergk (martinvonz)
- Waleed Khan (arxanas)
- Emily Shaffer (nasamuffin)
- Austin Seipp (thoughtpolice; yours truly)

Many thanks as well to emeritus member Khionu Sybiern, who helped kickstart this
whole process.

Signed-off-by: Austin Seipp <[email protected]>
@thoughtpolice thoughtpolice force-pushed the aseipp/push-xsqsllnzzswk branch from 52fbe51 to b942b1b Compare January 9, 2025 22:36
- Reviewing code submitted by others &mdash; with an eye to maintainability,
performance, code quality, and "style" (fitting in with the project).
- Participating in design discussions, especially with regards to architecture
or long-term vision.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would explicitly add something about making sure the community remains a welcoming place to users and contributors

Comment on lines +127 to +128
Maintainer in question). This can be due to lack of participation, conduct
violations, etc. Note that Maintainers are subject to a higher set of behavioral
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Maintainer in question). This can be due to lack of participation, conduct
violations, etc. Note that Maintainers are subject to a higher set of behavioral
Maintainer in question). This can be due to lack of participation or conduct violations. Note that Maintainers are subject to a higher set of behavioral

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, it seems to explicitly limit the reasons to remove a Maintainer to the two listed here, and not allow for any others. Is that intentional, or was this just meant to improve the wording? I imagine there could be some other legitimate reason, like lack of alignment with the project goals, or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants