-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs]: Add some more documentation on how to work with github. #915
[Docs]: Add some more documentation on how to work with github. #915
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
78c912e
to
8926b03
Compare
There are only a few things missing from this doc, but generally it's ready. |
8926b03
to
ad93cc0
Compare
Okay, I'll click the "Ready for review" button :) |
ad93cc0
to
31d5585
Compare
i'll need to tidy up the revsets section and then it's ready. If you see sentences which I could structure better, I'll gladly change them. |
31d5585
to
526d9f9
Compare
Since the last Revision, I removed both the Git and Mercurial sections and introduced @martinvonz suggestion as basic workflow. PTAL at both the revsets and the basic workflow section. Overall the doc was vastly simplified. |
526d9f9
to
9c8e99b
Compare
d391b14
to
ede6714
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have a lot of comments, but I think this is a good start. Thanks! Feel free to merge this as is, and then I'll probably go over it and send a follow-up PR later instead.
The document roughly describes some workflows, which help new users to start with github.
ede6714
to
b8af620
Compare
The document roughly describes some workflows, which help new users to start with github.
@superpippo12 Discord self ping.
Rendered
Checklist
If applicable:
CHANGELOG.md