Add ability to spawn a tty using a system command #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjcarstens
reviewed
Nov 6, 2021
| @@ -114,11 +114,28 @@ defmodule ExTTY do | |||
| {Elixir.IEx, :start, opts} | |||
| end | |||
|
|
|||
| defp shell_spawner(%{type: :muontrap, shell_opts: opts}) do | |||
There was a problem hiding this comment.
Suggested change
| defp shell_spawner(%{type: :muontrap, shell_opts: opts}) do | |
| defp shell_spawner(%{type: :system, shell_opts: opts}) do |
MuonTrap is an implementation detail. What if we generalize this to System?
There was a problem hiding this comment.
How about letting the user pass a :custom shell spawner that calls an arbitrary function?
I'd be for adding an example to the docs if that's direction that you go since I wouldn't have expected calling System.cmd to work well with this. I'm thrilled that it does, though.
fhunleth
reviewed
Nov 6, 2021
| args = Keyword.fetch!(opts, :args) | ||
| gl = Process.group_leader() | ||
|
|
||
| spawn(fn -> |
There was a problem hiding this comment.
Suggested change
| spawn(fn -> | |
| spawn_link(fn -> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you too do something like: