Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an error caused by node 14 #18

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Fix an error caused by node 14 #18

merged 2 commits into from
Apr 29, 2020

Conversation

linningmii
Copy link
Contributor

@linningmii linningmii commented Apr 27, 2020 •
edited
Loading

In node 14, number is not a valid data type of fs.writeFileSync.
image

Close #17

@linningmii
Fix an error caused by node 14
6a4d30a 
In node 14, number is not a valid data type of fs.writeFileSync.
@linningmii linningmii mentioned this pull request Apr 27, 2020
Closed
@anion155 anion155 mentioned this pull request Apr 29, 2020
Closed
@anion155
Copy link

There is also fs.writeFileSync(totalFilePath, progress.loaded);, where progress.loaded is number

@jkuri jkuri merged commit 50d9f87 into jkuri:master Apr 29, 2020
@jkuri
Copy link
Owner

jkuri commented Apr 29, 2020

thanks, I'll push updates to npm later.

@danrossi danrossi mentioned this pull request Nov 3, 2020
Closed
jbuckner added a commit to jbuckner/router-slot that referenced this pull request Jan 13, 2021
@jbuckner
Add Node 14 build support
bacba9b 
There's an issue with with node14 and `rollup-plugin-progress`, one of the dependencies of `@appnest/web-config`. This PR updates `@appnest/web-config` with the updated dependencies.

More info: jkuri/rollup-plugin-progress#18
This was referenced Jan 13, 2021
Open
Merged
jbuckner added a commit to internetarchive/router-slot that referenced this pull request Jan 19, 2021
@jbuckner
Add Node 14 build support (#3)
a34bca0 
There's an issue with with node14 and `rollup-plugin-progress`, one of the dependencies of `@appnest/web-config`. This PR updates `@appnest/web-config` with the updated dependencies.

More info: jkuri/rollup-plugin-progress#18
@isoden isoden mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build error using node 14 - TypeError
3 participants
@linningmii @anion155 @jkuri