Adds the ability to supply a non-default user, a uid, and a non-default group. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with allowing setting the u/g names, but I don't like setting uid. The purpose of the system parameter is to create a system user/group without having to know what uid/gids are free on an individual box. Could you remove that and squash everything into a single commit and I'll merge it? |
|
Alright, that's fair. I didn't quite look at the system parameter until just now, and that pretty much takes care of what I was concerned about. Good call out. I'll squash and remove the UID functionality now. |
…bana-<version> has the correct ownership, as on our Centos 6.6 boxes it was ending up with a uid of 501 and a group of 'games'.
|
Thanks! |
jlambert121
added a commit
that referenced
this pull request
Jul 28, 2015
Adds the ability to supply a non-default user, a uid, and a non-default group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those of us unlucky enough to work in environments where users and groups aren't controlled via ldap, it's helpful to be able to specify the user and uid of users created on systems.
Also I noticed that when kibana is extracted, ownership was set to '501:games' on the /opt/kibana-4.0.1. directory. I added an exec block just to ensure permissions are set consistently.