Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin support #68

Merged
merged 1 commit into from
Feb 9, 2016
Merged

add plugin support #68

merged 1 commit into from
Feb 9, 2016

Conversation

bilsch
Copy link

@bilsch bilsch commented Dec 15, 2015

hiera config to add / remove plugins also works

kibana::plugins:
marvel:
source: elasticsearch/marvel/latest

And to remove

kibana::plugins:
marvel:
source: elasticsearch/marvel/latest
ensure: absent

@bilsch
Copy link
Author

bilsch commented Dec 15, 2015

I'll work on getting the test suites added for this shortly

@bilsch
Copy link
Author

bilsch commented Dec 17, 2015

This should be ready for review. Let me know if you want more test cases added in

@bilsch
Copy link
Author

bilsch commented Jan 4, 2016

@jlambert121 mind taking a look at this?

@jlambert121
Copy link
Owner

This looks great - thanks! Would you add a test for removing a plugin and squish things down to a single commit and I'll merge it?

hiera config to add / remove plugins also works

kibana::plugins:
  marvel:
    source: elasticsearch/marvel/latest

And to remove

kibana::plugins:
  marvel:
    source: elasticsearch/marvel/latest
    ensure: absent
@bilsch
Copy link
Author

bilsch commented Feb 5, 2016

@jlambert121 ok tweaked the rspec tests and added the remove / absent test and squished to a single commit

@jlambert121
Copy link
Owner

Thanks!

jlambert121 added a commit that referenced this pull request Feb 9, 2016
@jlambert121 jlambert121 merged commit ac1978c into jlambert121:master Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants