Added the new config since kibana 4.2.x, support for custom log file and server.basePath #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for custom log file and server.basePath
|
@jlambert121 can you review this? |
|
This looks great, thanks! Could you add some tests around the version selection? |
|
@jlambert121 thnx, i added some tests, hope you like it! |
|
Thanks! Tests will save your butt some day. :) |
jlambert121
added a commit
that referenced
this pull request
Mar 3, 2016
Added the new config since kibana 4.2.x, support for custom log file and server.basePath
|
Thnx, can you release a new version of this module? |
|
2.5.0 pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since kibana 4.2.x they changed the syntax for the config file. An other feature is the server.basePath which allows you to add a root context path. This will fix #78