Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Windows CI failures #125

Merged
merged 15 commits into from
May 13, 2023
Merged

fix Windows CI failures #125

merged 15 commits into from
May 13, 2023

Conversation

jlchan
Copy link
Owner

@jlchan jlchan commented May 12, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #125 (493c233) into main (c44e281) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   97.33%   97.29%   -0.04%     
==========================================
  Files          25       25              
  Lines        2848     2848              
==========================================
- Hits         2772     2771       -1     
- Misses         76       77       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jlchan
Copy link
Owner Author

jlchan commented May 12, 2023

To start, CI passes on everything except Windows Julia 1. If we remove reference_element_tests.jl, it passes on Windows Julia 1

@jlchan jlchan changed the title debug Windows CI failures fix Windows CI failures May 13, 2023
@jlchan
Copy link
Owner Author

jlchan commented May 13, 2023

Had to remove the inverse_trace_constant test for Hex elements.

@jlchan jlchan merged commit a7e7967 into main May 13, 2023
@jlchan jlchan deleted the jc/windows_CI_failure branch May 13, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant