Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalBuilder ignores attributes #29

Closed
altavir opened this issue Oct 30, 2016 · 1 comment
Closed

TerminalBuilder ignores attributes #29

altavir opened this issue Oct 30, 2016 · 1 comment
Milestone
3.0.2

Comments

@altavir
Copy link

altavir commented Oct 30, 2016

It does. It uses them only in this line:

Pty pty = JnaNativePty.open(attributes, size);
@gnodet gnodet closed this as completed in e5a38bc Nov 3, 2016
@gnodet
Copy link
Member

gnodet commented Nov 3, 2016

I don't think the attributes and size on the builder should be used for system terminals.

gnodet added a commit that referenced this issue Nov 4, 2016
@gnodet
TerminalBuilder now logs a warning for ignored attributes, fixes #29
066491e
@gnodet gnodet added this to the 3.0.2 milestone Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

No branches or pull requests
2 participants
@gnodet @altavir