3.8.0 regression with color support on ConEMU

[bdw429s]

Upgrading from JLine 3.7.0 to 3.8.0 has a regression which now causes ConEMU to report as only supporting 8 colors instead of 256 colors. In both cases, org.jline.terminal.impl.jna.win.JnaWinSysTerminal is the terminal class in use.

Jline 3.7.0 running the system-colors command in CommandBox 4.1:

Jline 3.8.0 running the system-colors command in CommandBox 4.1:

[gnodet]

Two questions:

• is the behavior specific to Windows 10 ?
• what is the type set on the terminal terminal.getType() ?

[bdw429s]

@gnodet Thanks for the reply.

is the behavior specific to Windows 10 ?

I haven't tried it on Windows 10. My main PC is Windows 7.
I just tried it on Windows 10 and I get the same behavior there as Windows 7.

what is the type set on the terminal terminal.getType() ?

I get null

[gnodet]

Ok, I think null is the problem here, I'll investigate.

[gnodet]

Could you try the following patch ?
https://github.com/jline/jline3/tree/issue-294

[bdw429s]

@gnodet I built the code on that branch and it seems to have fixed the regression. 256 colors are back in ConEMU. Thanks!

Any idea what version this will release in? I was hoping to include 3.8.0 in CommandBox due to some other fixes you had put in there for me but I'll need to wait until this fix going into a stable version.

[gnodet]

JLine 3.8.2 should be available shortly in central.

[bdw429s]

Thanks again @gnodet !