Fix non-synchronized access to handlers map #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user modifies the `handlers` map from his thread. However, when a signal is raised, it's on another thread: on Windows it's `WindowsStreamPump`. Therefore this map is accessed from 2 threads without synchronization. The error manifests as handler not being called. For unknown reason, we only observed it on Windows, but it seems the issue also affects Linux terminals.
viliam-durina
added a commit
to cangencer/hazelcast-jet
that referenced
this pull request
Dec 21, 2020
mattirn
force-pushed
the
master
branch
2 times, most recently
from
415aba8 to
e1c75ce
Compare
ufukyilmaz
pushed a commit
to hazelcast/hazelcast-jet
that referenced
this pull request
Dec 30, 2020
* Use JLine to read sql lines * Add basic multiline support * Add a way to cancel a streaming query * Add SQL CLI documentation * Workaround the jline race in signal handlers See jline/jline3#629 * Allow special commands to run without semicolon Co-authored-by: Ufuk <[email protected]> Co-authored-by: Viliam Durina <[email protected]> Co-authored-by: Marko Topolnik <[email protected]>
viliam-durina
added a commit
to gierlachg/hazelcast-jet
that referenced
this pull request
Jan 7, 2021
* Use JLine to read sql lines * Add basic multiline support * Add a way to cancel a streaming query * Add SQL CLI documentation * Workaround the jline race in signal handlers See jline/jline3#629 * Allow special commands to run without semicolon Co-authored-by: Ufuk <[email protected]> Co-authored-by: Viliam Durina <[email protected]> Co-authored-by: Marko Topolnik <[email protected]>
mattirn
force-pushed
the
master
branch
2 times, most recently
from
8e035a1 to
2c53681
Compare
|
bump |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user modifies the
handlersmap from his thread. However, when asignal is raised, it's on another thread: on Windows it's
WindowsStreamPump. Therefore this map is accessed from 2 threadswithout synchronization.
The error manifests as handler not being called. For unknown reason, we
only observed it on Windows, but it seems the issue also affects Linux
terminals.