Fix path generation on non-posix systems #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the issue I talked about here.
Using
path.join
generates a path that uses platform's separator. But it seems karma uses posix style everywhere, so path should explicitly use posix, otherwise it breaks on Windows.I do not really know how to make a unit test for this.
For reference, without this fix, 7.0.4 gives this kind of output on Windows:
So no error, but 0 test running ^^