Fixed batchExecutor to not be useless #346
Open
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 this would be great to have! |
|
+1 How can we make this happen? |
|
Would be nice to solve merge conflicts |
m417z
force-pushed
the
fixed-batchexecutor
branch
from
d964a3f to
f1e9cf2
Compare
m417z
force-pushed
the
fixed-batchexecutor
branch
from
f1e9cf2 to
97eb493
Compare
|
@Lusitaniae done. Hopefully @jloosli will merge it soon to avoid more conflicts in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promise.all()doesn't trigger the promises to start their work, creating the promise itself does. Reference:https://stackoverflow.com/a/40639551
Currently, all
batchExecutordoes is waiting for the promises in chunks, but they're still all executed in parallel. This pull request changes the code so that instead of (already running) promises, promise generator functions are passed, so that the promises are created (and actually executed) in chunks.Another unfixed issue is that
batchExecutoris used recursively, so if the batch limit is, say, 50, and the tree depth is 3, the limit is actually50^3=125000since eachbatchExecutorinstance manages its own limit.