Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update assignment-1.md #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update assignment-1.md #138

wants to merge 1 commit into from

Conversation

mbabaie
Copy link
Contributor

@mbabaie mbabaie commented Jan 11, 2021

No description provided.

powerjg
powerjg requested changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@powerjg powerjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just one small thing :)

assignments/assignment-1.md
@@ -1,6 +1,6 @@
---
Authors: Jason Lowe-Power, Filipe Eduardo Borges
Editor: Justin Perona, Julian Angeles, Maryam Babaie
Editor: Maryam Babaie
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the whole list here :). Might as well give everyone credit.

Suggested change
Editor: Maryam Babaie
Editor: Maryam Babaie, Justin Perona, Julian Angeles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerjg powerjg powerjg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbabaie @powerjg