Fix previousInclude and previousExclude checks. #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation requires you to always define
:include
AND:exclude
for search to work. For example, if you do the following:Then attempt to search, you will receive the following JS error:
By doing the following, the error goes away:
There is no reason to require the developer to have the empty
:include
just to get searching working. So this fix will break the checks apart forpreviousInclude
andpreviousExclude
to resolve this issue.