Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reading pgn library from binary #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nurmukhametdaniyar
Copy link

Hey

I started using this library and encountered the problem where I need to read from buffer instead of reading from a file, so I added a small function to read from buffer

Hope it helps

@nurmukhametdaniyar
Copy link
Author

I was also able to avoid issue #24 after using reading from the buffer

@jmagnuson
Copy link
Owner

Thanks, I like this idea. I wonder if there's a way to generalize it to take a iterator of bytes, maybe using something like Bytes or something compatible with nom? That should help more constrained systems which might not have the ability to buffer the entire dbc. I'll take a look soon if someone doesn't beat me to it.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #30 (2d71923) into master (116c4cd) will decrease coverage by 1.78%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   68.88%   67.09%   -1.79%     
==========================================
  Files           5        5              
  Lines         601      617      +16     
==========================================
  Hits          414      414              
- Misses        187      203      +16     
Impacted Files Coverage Δ
src/pgn.rs 62.89% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116c4cd...2d71923. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants