New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming file reads + more #2

Open

mic159 wants to merge 6 commits into jmoiron:master from mic159:feature/verify

Contributor

mic159 commented Mar 19, 2016

I have made a few changes to improve the library:

Stream the file in instead of reading the whole file then using substrings.
Don't parse the header twice (once to determine the type, then again inside).
Verify the packet with the checksum in the header
Parse Main packets
Parse InputFileSliceChecksum packets

mic159 added 6 commits

January 10, 2016 18:37


          Adding MainPacket parsing


          Adding Checksum packet parsing

75e206f


          Fully verify the packet headers

2afa2ab


          Ignore pycharm

bd7b6f5


          Don't double parse headers

4d42004


          Stream file reading instead of having it all in memory

2ec713c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet