Use template strings intstead of string literals with htmbars-inline-precompile #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Little bit of extra context. I found this out when I tried to copy over these tests for use in a library consumed by glimmer applications. Figured I'd see if the codemod I wrote there would be helpful here too. Cheers 🍻 |
|
Mind rebasing now that master is green? |
htmbars-inline-precompile In htmlbars-inline-precompile both string literals and template strings are supported, but in `glimmer-inline-precompile` you may only pass a template literal. I ran a codemod to change all these in our unit tests to bring this in line to the other precompile lib
rondale-sc
force-pushed
the
use-tagged-templates-with-hbs-helper-rather-than-literals
branch
from
b5839db to
b38310c
Compare
|
@rwjblue Should be gtg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In htmlbars-inline-precompile both string literals and template strings
are supported, but in
glimmer-inline-precompileyou may only pass atemplate literal.
I ran a codemod to change all these in our unit tests to bring this in
line to the other precompile lib