Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about short circuiting #94

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Add note about short circuiting #94

merged 1 commit into from
Sep 5, 2019

Conversation

danwenzel
Copy link
Contributor

@danwenzel danwenzel commented Sep 4, 2019 •
edited
Loading

The fact that the or and and helpers do not short-circuit can trip up developers, as talked about here: #58

This PR updates the documentation to give reference to this gotcha

rwjblue
rwjblue approved these changes Sep 5, 2019
View reviewed changes
Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rwjblue rwjblue merged commit 2d3f016 into jmurphyau:master Sep 5, 2019
@danwenzel danwenzel deleted the patch-1 branch September 5, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danwenzel @rwjblue