Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxjs-compat need #216

Closed
beradrian opened this issue Dec 3, 2018 · 2 comments
Closed

rxjs-compat need #216

beradrian opened this issue Dec 3, 2018 · 2 comments

Comments

@beradrian
Copy link

I think rxjs-compat is needed. You could replace imports like import { Subject } from "rxjs/Subject" with import { Subject } from "rxjs'

@joanllenas
Copy link
Owner

Hi @beradrian ,
the current stable version uses rxjs v5.5, the one on master is already migrated to rxjs v6 and all imports follow that pattern.

The version on master depends on date-fns v2, which is on alpha.25 right now, so when it is released I will finish the migration and release as well.

Thanks for reporting,
cheers!

joanllenas added a commit that referenced this issue Jan 21, 2019
BREAKING CHANGE: This version requires Angular >= v6 and RxJs >= v6

#216
@joanllenas
Copy link
Owner

Hi @beradrian
The latest release doesn't need compat anymore.
I decided to make the upgrade since date-fns v2 is taking so much longer than I first thought.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants