Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run mode hooks in eglot--format-markup #327

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

xuchunyang
Copy link
Contributor

Since we want only the syntax highlight provided by the major mode, it makes sense to ignore user's customization functions on the major mode's hook.

@joaotavora
Copy link
Owner

Makes sense indeed. Do you have copyright assignment to the FSF?

@xuchunyang
Copy link
Contributor Author

I signed the copyright assignment for the Emacs project some years ago, but I've never needed it, and I am not sure if it is still working.

@joaotavora joaotavora merged commit 2ab8b59 into joaotavora:master Oct 27, 2019
@joaotavora
Copy link
Owner

I believe it is: I am not sure if it is still working.

Hmmm. I don't think it has an expiration date. The patch is small enough to go in regardless, so, on the safe side, i added a "Copyright-paperwork-exempt: yes" line.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants