Fix #638: Convert colon to hex in URI #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the code touches same areas as #637, but they still seem compatible. |
* eglot.el (eglot--uri-path-allowed-chars): define what characters are allowed in an URI. Specifically, convert ':' to '%3A' on windows. * eglot.el (eglot--path-to-uri): ensure that the colon in 'file://' stays with a colon, but hexify others.
|
Added a test to show that |
|
I pushed this with some minor tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we need to convert the directory colon to a hex value, and the current implementation doesn't do that.
On close examination on both
lsp-modeandvscodeI see that all uris are on the formfile:///c%3A/Users/foo/bar, notfile:///c:/Users/foo/barThis commit addresses that by creating the new
defconstand passing it on to hexify.This was a convoluted bug to fix - suddenly flymake behaves! 😄