yas-maybe-load-snippet-buffer moves point every time I save a snippet

[gsingh93]

I'm running this command:

emacs -Q -L ~/.emacs.d/elpa/yasnippet-20200604.246 --eval "(require 'yasnippet)"  ~/code/tmp/foo

The foo file looks like this:

# -*- mode: snippet -*-
# --
line1
line2

Whenever I modify the file and save it, no matter where point is it always jumps back to (point-min). I used profiler-start/profiler-report to track this down to a call to yas-maybe-load-snippet-buffer which is run as a hook on save.

Is this the intended behavior? If so, is there a way to change it? I'm on Emacs 28.2 on macOS.

[demonaarwu]

@gsingh93

  (add-hook 'snippet-mode-hook (lambda ()
                                 (make-local-variable 'after-save-hook)
                                 (setq after-save-hook nil)))

Try this.
I faced the same problem, and eventually I found this solution.

[monnier]

Could you try the patch below: ``` diff --git a/yasnippet.el b/yasnippet.el index 782c440588..3f007daa84 100644 --- a/yasnippet.el +++ b/yasnippet.el @@ -2784,18 +2784,20 @@ (defun yas-maybe-load-snippet-buffer () "Added to `after-save-hook' in `snippet-mode'." + (save-excursion ;; Issue #1146. Here or in `yas--parse-template`? (let* ((mode (intern (file-name-sans-extension (file-name-nondirectory (directory-file-name default-directory))))) (current-snippet (apply #'yas--define-snippets-2 (yas--table-get-create mode) + ;; FIXME: `yas-load-snippet-buffer' will *re*parse! (yas--parse-template buffer-file-name))) (uuid (yas--template-uuid current-snippet))) (unless (equal current-snippet (if uuid (yas--get-template-by-uuid mode uuid) (yas--lookup-snippet-1 (yas--template-name current-snippet) mode))) - (yas-load-snippet-buffer mode t)))) + (yas-load-snippet-buffer mode t))))) (defun yas-load-snippet-buffer-and-close (table &optional kill) "Load and save the snippet, then `quit-window' if saved. ```

[demonaarwu]

@monnier

Thanks :)
The patch works.