Skip to content

Commit

Permalink
removing extra methods and updating common
Browse files Browse the repository at this point in the history
  • Loading branch information
karllhughes committed Aug 12, 2015
1 parent 581bd82 commit e825f2a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 22 deletions.
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
# Changelog
All Notable changes to `jobs-dice` will be documented in this file

## 0.2.4 - 2015-08-12

### Added
- Nothing

### Deprecated
- Nothing

### Fixed
- Updated to v1.0.3 of jobs-common

### Removed
- getParameters and parseLocation methods

### Security
- Nothing

## 0.2.3 - 2015-07-25

### Added
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
],
"require": {
"php": ">=5.5.0",
"jobbrander/jobs-common": "~1.0"
"jobbrander/jobs-common": "~1.0.3"
},
"require-dev": {
"phpunit/phpunit": "3.7.*",
Expand Down
22 changes: 1 addition & 21 deletions src/Dice.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function createJobObject($payload)
'location' => $payload['location'],
]);

$location = $this->parseLocation($payload['location']);
$location = static::parseLocation($payload['location']);

$job->setCompany($payload['company'])
->setDatePostedAsString($payload['date']);
Expand Down Expand Up @@ -65,16 +65,6 @@ public function getListingsPath()
return 'resultItemList';
}

/**
* Get parameters
*
* @return array
*/
public function getParameters()
{
return [];
}

/**
* Get query string for client based on properties
*
Expand Down Expand Up @@ -123,14 +113,4 @@ public function getVerb()
{
return 'GET';
}

/**
* Parse city and state from string given by API
*
* @return array
*/
public function parseLocation($location)
{
return explode(', ', $location);
}
}

0 comments on commit e825f2a

Please sign in to comment.