Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "jump to top" functionality #190

Merged
merged 2 commits into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/com/capyreader/app/MainActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.os.StrictMode.ThreadPolicy
import android.os.StrictMode.setThreadPolicy
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.activity.enableEdgeToEdge
import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue
import com.capyreader.app.common.AppPreferences
Expand All @@ -16,6 +17,7 @@ import org.koin.compose.koinInject
class MainActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
enableStrictModeOnDebug()
enableEdgeToEdge()
super.onCreate(savedInstanceState)
val theme = get<AppPreferences>().theme

Expand Down
69 changes: 56 additions & 13 deletions app/src/main/java/com/capyreader/app/ui/articles/ArticleLayout.kt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ import androidx.compose.material3.Scaffold
import androidx.compose.material3.SnackbarHost
import androidx.compose.material3.SnackbarHostState
import androidx.compose.material3.TopAppBar
import androidx.compose.material3.TopAppBarDefaults.pinnedScrollBehavior
import androidx.compose.material3.TopAppBarScrollBehavior
import androidx.compose.material3.TopAppBarState
import androidx.compose.material3.adaptive.ExperimentalMaterial3AdaptiveApi
import androidx.compose.material3.adaptive.layout.ListDetailPaneScaffoldRole
import androidx.compose.material3.adaptive.navigation.rememberListDetailPaneScaffoldNavigator
Expand Down Expand Up @@ -115,13 +118,19 @@ fun ArticleLayout(
scaffoldNavigator.navigateTo(ListDetailPaneScaffoldRole.Detail)
}

val navigateFromDrawerToList = suspend {
val openNextList = suspend {
scaffoldNavigator.navigateTo(ListDetailPaneScaffoldRole.List)
listState.scrollToItem(0)
delay(200)
listState.scrollToItem(0)
drawerState.close()
}

val closeDrawer = {
coroutineScope.launch {
drawerState.close()
}
}

val showSnackbar = { message: String ->
coroutineScope.launch {
snackbarHost.showSnackbar(message)
Expand All @@ -137,6 +146,12 @@ fun ArticleLayout(
}
}

val jumpToTop = {
coroutineScope.launch {
listState.scrollToItem(0)
}
}

ArticleScaffold(
drawerState = drawerState,
scaffoldNavigator = scaffoldNavigator,
Expand All @@ -145,23 +160,31 @@ fun ArticleLayout(
folders = folders,
feeds = feeds,
onSelectFolder = {
webViewNavigator.clearView()
onSelectFolder(it)
coroutineScope.launch {
navigateFromDrawerToList()
if (!filter.isFolderSelect(it)) {
webViewNavigator.clearView()
onSelectFolder(it.title)
coroutineScope.launch {
openNextList()
}
} else {
closeDrawer()
}
},
onSelectFeed = {
webViewNavigator.clearView()
coroutineScope.launch {
onSelectFeed(it)
navigateFromDrawerToList()
if (!filter.isFeedSelected(it)) {
webViewNavigator.clearView()
onSelectFeed(it.id)
openNextList()
} else {
closeDrawer()
}
}
},
onFeedAdded = { feedID ->
coroutineScope.launch {
onSelectFeed(feedID)
navigateFromDrawerToList()
openNextList()

showSnackbar(addFeedSuccessMessage)

Expand All @@ -172,9 +195,13 @@ fun ArticleLayout(
},
onNavigateToSettings = onNavigateToSettings,
onFilterSelect = {
onSelectArticleFilter()
coroutineScope.launch {
navigateFromDrawerToList()
if (!filter.hasArticlesSelected()) {
onSelectArticleFilter()
coroutineScope.launch {
openNextList()
}
} else {
closeDrawer()
}
},
filter = filter,
Expand All @@ -183,14 +210,20 @@ fun ArticleLayout(
)
},
listPane = {
val scrollBehavior = pinnedBehavior(filter)

Scaffold(
modifier = Modifier
.nestedScroll(scrollBehavior.nestedScrollConnection),
topBar = {
TopAppBar(
scrollBehavior = scrollBehavior,
title = {
FilterAppBarTitle(
filter = filter,
allFeeds = allFeeds,
folders = folders,
onRequestJumpToTop = { jumpToTop() }
)
},
navigationIcon = {
Expand Down Expand Up @@ -320,6 +353,16 @@ fun findCurrentFeed(filter: ArticleFilter, feeds: List<Feed>): Feed? {
return null
}

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun pinnedBehavior(filter: ArticleFilter): TopAppBarScrollBehavior {
val topAppBarState = rememberSaveable(filter, saver = TopAppBarState.Saver) {
TopAppBarState(0f, 0f, 0f)
}

return pinnedScrollBehavior(topAppBarState)
}

@Preview
@Composable
fun ArticleLayoutPreview() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package com.capyreader.app.ui.articles

import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.systemBarsPadding
import androidx.compose.foundation.layout.systemGesturesPadding
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.LazyListState
import androidx.compose.runtime.Composable
Expand Down Expand Up @@ -41,7 +45,8 @@ fun ArticleList(
}

LazyColumn(
modifier = Modifier.fillMaxSize(),
modifier = Modifier
.fillMaxSize(),
state = listState,
) {
items(
Expand Down
27 changes: 27 additions & 0 deletions app/src/main/java/com/capyreader/app/ui/articles/ArticleRow.kt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ import androidx.compose.foundation.combinedClickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.asPaddingValues
import androidx.compose.foundation.layout.aspectRatio
import androidx.compose.foundation.layout.calculateEndPadding
import androidx.compose.foundation.layout.calculateStartPadding
import androidx.compose.foundation.layout.displayCutout
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
Expand All @@ -18,6 +24,7 @@ import androidx.compose.material3.ListItemDefaults
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.MaterialTheme.colorScheme
import androidx.compose.material3.MaterialTheme.typography
import androidx.compose.material3.Surface
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.Stable
Expand All @@ -29,6 +36,7 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.hapticfeedback.HapticFeedbackType
import androidx.compose.ui.layout.ContentScale
import androidx.compose.ui.platform.LocalHapticFeedback
import androidx.compose.ui.platform.LocalLayoutDirection
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextOverflow
Expand Down Expand Up @@ -188,6 +196,17 @@ private fun ArticleImage(
@Composable
fun PlaceholderArticleRow(imagePreview: ImagePreview) {
ListItem(
supportingContent = {
if (imagePreview == ImagePreview.LARGE) {
Surface(
Modifier
.fillMaxWidth()
.aspectRatio(3 / 2f)
.background(colorScheme.surfaceContainer)
.clip(RoundedCornerShape(8.dp))
) {}
}
},
trailingContent = {
if (imagePreview == ImagePreview.SMALL) {
Box(
Expand Down Expand Up @@ -333,3 +352,11 @@ fun ArticleRowPreview_Unread() {
currentTime = LocalDateTime.now(),
)
}

@Preview
@Composable
fun ArticleRowPreviewPlaceholder() {
CapyTheme {
PlaceholderArticleRow(ImagePreview.LARGE)
}
}
36 changes: 15 additions & 21 deletions app/src/main/java/com/capyreader/app/ui/articles/ArticleScaffold.kt
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
package com.capyreader.app.ui.articles

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.material3.DrawerState
import androidx.compose.material3.DrawerValue
import androidx.compose.material3.ModalDrawerSheet
Expand All @@ -17,11 +15,11 @@ import androidx.compose.material3.adaptive.navigation.ThreePaneScaffoldNavigator
import androidx.compose.material3.adaptive.navigation.rememberListDetailPaneScaffoldNavigator
import androidx.compose.material3.rememberDrawerState
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.tooling.preview.Devices
import androidx.compose.ui.tooling.preview.Preview
import com.capyreader.app.ui.components.safeEdgePadding
import com.capyreader.app.ui.theme.CapyTheme

@OptIn(ExperimentalMaterial3AdaptiveApi::class)
Expand All @@ -42,25 +40,21 @@ fun ArticleScaffold(
}
},
) {
Column(
horizontalAlignment = Alignment.CenterHorizontally,
modifier = Modifier.fillMaxWidth()
) {
ListDetailPaneScaffold(
directive = scaffoldNavigator.scaffoldDirective,
value = scaffoldNavigator.scaffoldValue,
listPane = {
AnimatedPane {
listPane()
}
},
detailPane = {
AnimatedPane {
detailPane()
}
ListDetailPaneScaffold(
modifier = Modifier.safeEdgePadding(),
directive = scaffoldNavigator.scaffoldDirective,
value = scaffoldNavigator.scaffoldValue,
listPane = {
AnimatedPane {
listPane()
}
},
detailPane = {
AnimatedPane {
detailPane()
}
)
}
}
)
}
}

Expand Down
6 changes: 4 additions & 2 deletions app/src/main/java/com/capyreader/app/ui/articles/FeedList.kt
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import com.jocmp.capy.ArticleStatus
import com.jocmp.capy.Feed
import com.jocmp.capy.Folder
import com.capyreader.app.R
import com.capyreader.app.ui.components.safeEdgePadding
import com.capyreader.app.ui.fixtures.FeedPreviewFixture
import com.capyreader.app.ui.fixtures.FolderPreviewFixture
import com.capyreader.app.ui.navigationTitle
Expand All @@ -43,8 +44,8 @@ fun FeedList(
folders: List<Folder> = emptyList(),
feeds: List<Feed> = emptyList(),
onFilterSelect: () -> Unit,
onSelectFolder: (folderTitle: String) -> Unit,
onSelectFeed: (feedID: String) -> Unit,
onSelectFolder: (folder: Folder) -> Unit,
onSelectFeed: (feed: Feed) -> Unit,
onFeedAdded: (feedID: String) -> Unit,
onSelectStatus: (status: ArticleStatus) -> Unit,
onNavigateToSettings: () -> Unit,
Expand All @@ -60,6 +61,7 @@ fun FeedList(

Column(
Modifier
.safeEdgePadding()
.fillMaxSize()
) {
Column(
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/com/capyreader/app/ui/articles/FeedRow.kt
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ import com.capyreader.app.ui.fixtures.FeedPreviewFixture
fun FeedRow(
selected: Boolean,
feed: Feed,
onSelect: (id: String) -> Unit,
onSelect: (feed: Feed) -> Unit,
) {
NavigationDrawerItem(
icon = { FaviconBadge(url = feed.faviconURL) },
label = { ListTitle(feed.title) },
badge = { CountBadge(count = feed.count) },
selected = selected,
onClick = {
onSelect(feed.id)
onSelect(feed)
}
)
}
Expand Down
Loading
Loading