Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show alt text in image viewer #513

Merged
merged 3 commits into from
Nov 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions app/src/main/java/com/capyreader/app/common/Media.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package com.capyreader.app.common

import androidx.compose.runtime.MutableState
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.saveable.Saver
import kotlinx.serialization.Serializable
import kotlinx.serialization.encodeToString
import kotlinx.serialization.json.Json

@Serializable
data class Media(
val url: String,
val altText: String?
)

val Media.Companion.Saver
get() = Saver<MutableState<Media?>, String>(
save = { state ->
Json.encodeToString(state.value)
},
restore = { jsonString ->
mutableStateOf(Json.decodeFromString(jsonString))
}
)
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import android.webkit.JavascriptInterface
import com.jocmp.capy.common.optionalURL

class WebViewInterface(
private val navigateToMedia: (url: String) -> Unit,
private val navigateToMedia: (media: Media) -> Unit,
) {
@JavascriptInterface
fun openImage(src: String) {
fun openImage(src: String, altText: String?) {
optionalURL(src)?.let {
navigateToMedia(it.toString())
navigateToMedia(Media(url = src, altText = altText))
}
}

Expand Down
26 changes: 14 additions & 12 deletions app/src/main/java/com/capyreader/app/ui/articles/ArticleLayout.kt
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ import androidx.compose.ui.tooling.preview.Preview
import androidx.paging.PagingData
import androidx.paging.compose.collectAsLazyPagingItems
import com.capyreader.app.R
import com.capyreader.app.common.Media
import com.capyreader.app.common.Saver
import com.capyreader.app.refresher.RefreshInterval
import com.capyreader.app.ui.articles.detail.ArticleView
import com.capyreader.app.ui.articles.detail.CapyPlaceholder
Expand Down Expand Up @@ -121,7 +123,7 @@ fun ArticleLayout(
listState = listState,
scrollBehavior = scrollBehavior
)
var mediaUrl by rememberSaveable { mutableStateOf<String?>(null) }
var media by rememberSaveable(saver = Media.Saver) { mutableStateOf(null) }
val focusManager = LocalFocusManager.current
val openUpdatePasswordDialog = {
onUnauthorizedDismissRequest()
Expand All @@ -134,7 +136,7 @@ fun ArticleLayout(

val webViewState = rememberWebViewState(
onNavigateToMedia = {
mediaUrl = it
media = it
},
)

Expand Down Expand Up @@ -373,7 +375,7 @@ fun ArticleLayout(
},
onToggleRead = onToggleArticleRead,
onToggleStar = onToggleArticleStar,
enableBackHandler = mediaUrl == null,
enableBackHandler = media == null,
onRequestArticle = { id ->
coroutineScope.launchUI {
onSelectArticle(id)
Expand All @@ -393,13 +395,13 @@ fun ArticleLayout(
AnimatedVisibility(
enter = fadeIn(),
exit = fadeOut(),
visible = mediaUrl != null
visible = media != null
) {
ArticleMediaView(
onDismissRequest = {
mediaUrl = null
media = null
},
url = mediaUrl,
media = media
)
}

Expand Down Expand Up @@ -428,27 +430,27 @@ fun ArticleLayout(
}
}

BackHandler(mediaUrl != null) {
mediaUrl = null
BackHandler(media != null) {
media = null
}

BackHandler(mediaUrl == null && search.isActive && article == null) {
BackHandler(media == null && search.isActive && article == null) {
search.clear()
}

ArticleListBackHandler(
enabled = isFeedActive(mediaUrl, article, search)
enabled = isFeedActive(media, article, search)
) {
toggleDrawer()
}
}

fun isFeedActive(
mediaURL: String?,
media: Media?,
article: Article?,
search: ArticleSearch
): Boolean {
return mediaURL == null &&
return media == null &&
article == null &&
!search.isActive
}
Expand Down
Loading