Dismiss notifications on read

[jocmp]

Ref

• Add "Mark read" intent to article notifications #462

[sandboiii]

Hey, I really wanted to clear notifications on read and made the following simple implementation:
sandboiii@fb34b46

Does it really necessary to store all the information of notifications in db? Looks like a bit of over-engineering to me

[jocmp]

@sandboiii hey! I hear you about the over-engineering. My first implementation was about the same that you had. The problem is the group notification, the one that bundles all the article notifications together. The group notification appear as an empty stub after you clear the last article which looks bad.

Based on this old danlew post I decided to track these in a DB. That way when all notifications are clear the group notification can also be dismissed.

https://github.com/jocmp/capyreader/pull/705/files#diff-07abb723eee2da7a6c31ed4828d50fee0ed36067bb57f22a7c53fa2604628193R54-R56

There's another API that tracks this called getActiveNotifications, but that doesn't work either since it can report the wrong notification amount if all articles are dismissed simultaneously.

[sandboiii]

it can report the wrong notification amount

Really? How do you know this?

[jocmp]

I noticed it while testing 10+ notifications. Plus the API does not guarantee that the activeNotifications will be updated immediately.

So take the following example

notificationIDs.forEach { // assume 3 notifications
  notificationManager.cancel(it)
}

print(notificationManager.activeNotifications.size)

what I noticed was the following - sometimes the notification size was immediately updated, sometimes the delay meant the size was still a number ranging from 1 to the max. In any case, the size isn't guaranteed to be 0 after the last cancel.

cancel
cancel 
cancel

size // #=> any number from 0 to 3