Add horizontal paging to reader #718
Merged
+251
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Paging works, shows correct articles - Full content works via [onRequestArticle] Open questions - [scrollToPage] works, but does update article list as it goes?
jocmp
force-pushed
the
jc/670/horizontal-paging
branch
from
20c723e to
d704e41
Compare
jocmp
force-pushed
the
jc/670/horizontal-paging
branch
from
c1a31e2 to
6599c60
Compare
jocmp
force-pushed
the
jc/670/horizontal-paging
branch
from
8678276 to
5caaafa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
getif snapshot item is a placeholderBeyondViewportPageCountto 1 or 2Ref