Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Local] Fix HTML escaped characters in titles #757

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[Local] Fix HTML escaped characters in titles #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion capy/src/main/java/com/jocmp/capy/accounts/local/ParsedItem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.jocmp.capy.accounts.local

import com.jocmp.rssparser.model.RssItem
import org.jsoup.Jsoup
import org.jsoup.safety.Cleaner
import org.jsoup.safety.Safelist
import java.net.URI
import java.net.URL
Expand Down Expand Up @@ -34,7 +35,11 @@ internal class ParsedItem(private val item: RssItem, private val siteURL: String
}

val title: String
get() = Jsoup.clean(item.title.orEmpty(), Safelist.none())
get() {
val cleaner = Cleaner(Safelist.none())

return cleaner.clean(Jsoup.parse(item.title.orEmpty())).text()
}

val imageURL: String?
get() = cleanedURL(item.image)?.toString()
Expand Down
4 changes: 2 additions & 2 deletions capy/src/test/java/com/jocmp/capy/accounts/local/ParsedItemTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ class ParsedItemTest {
@Test
fun title_withNestedHTML() {
val title =
"<mark>The `&lt;details&gt;` and `&lt;summary&gt;` elements are getting an upgrade</mark>"
"<mark>The `&lt;details&gt;` &amp; `&lt;summary&gt;` elements are getting an upgrade</mark>"

val item = RssItem.Builder().title(title).build()
val parsedItem = ParsedItem(item, siteURL = "")

assertEquals(
expected = "The `&lt;details&gt;` and `&lt;summary&gt;` elements are getting an upgrade",
expected = "The `<details>` & `<summary>` elements are getting an upgrade",
actual = parsedItem.title
)
}
Expand Down
Loading