Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Behaviour of Falsey Boolean Variants #24

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

joe-bell
Copy link
Owner

@joe-bell joe-bell commented Mar 22, 2022

Description

Currently, false boolean variants don't work as expected. Somewhere cva is probably considering these variants false and ignoring them, rather than actually using them

Additionally, allow disabling of defaultVariants by passing an explicit null

  • Add tests to check for false boolean variants (and null values to disabled them)
  • Add the actual fix for this behaviour

Additional context

Follow-up to #21


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@joe-bell
Copy link
Owner Author

(these tests should fail until a fix is added)

@joe-bell joe-bell force-pushed the fix/false-boolean-variants branch from 8db468c to 140ca1a Compare March 31, 2022 18:35
@joe-bell joe-bell marked this pull request as ready for review April 5, 2022 08:31
@joe-bell joe-bell merged commit ac03505 into main Apr 5, 2022
@joe-bell joe-bell deleted the fix/false-boolean-variants branch April 5, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant