-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
Have you considered |
Nice! I will check it out. |
I choose |
This is done by adding an `import` statement for a package (provided by `gopkgs`) for `gocode` only
8769f46
to
c55853e
Compare
@zmb3 or @joefitzgerald can anybody pls review this 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a spec with a fixture that doesn't import a package to actually flesh this out?
lib/go.js
Outdated
'use babel' | ||
|
||
let goVersion | ||
export function version (goconfig) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty similar to the locator code. Can we reuse any of that? Are we duplicating work here?
Thanks @lloiser!! |
This is done by (temporarily) adding an
import "..."
statement into the code so thatgocode
can find the package and provide suggestions for it.It is still rough on the edges especially for vendored packages.
Possible improvements:
import "..."
when a suggestion is selected (nice to have, will be added bygoimports
on save anyway)pkg
map ingo.js
does not grow if new packages are added (low prio)Fixes #665