Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to 0.27.2 #1

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Updated to 0.27.2 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .guardian.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
files: ./shard.yml
run: shards install
---
files: ./**/*.cr
run: crystal spec
run: crystal build ./src/readability.cr
---
files: ./shard.yml
run: crystal deps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, crystal deps got removed, better to change back to shards install.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah what the hell happened there. Ah well I'll fix in master, thanks for noticing 👍

2 changes: 1 addition & 1 deletion shard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ version: 0.1.0
authors:
- joenas <[email protected]>

crystal: 0.26.1
crystal: 0.27.2

license: MIT
32 changes: 16 additions & 16 deletions spec/readability_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe Readability do
</html>
HTML

it "transformMisusedDivsIntoParagraphs" do
context "transformMisusedDivsIntoParagraphs" do
it "should transform divs containing no block elements into <p>s" do
doc = Readability::Document.new(simple_html_fixture)
doc.transform_misused_divs_into_paragraphs!
Expand All @@ -70,7 +70,7 @@ describe Readability do
end
end

it "author" do
context "author" do
it "should pick up <meta name='dc.creator'></meta> as an author" do
doc = Readability::Document.new(<<-HTML)
<html>
Expand Down Expand Up @@ -139,7 +139,7 @@ describe Readability do
end
end

it "score_node" do
context "score_node" do
doc = Readability::Document.new(<<-HTML)
<html>
<body>
Expand Down Expand Up @@ -168,7 +168,7 @@ describe Readability do
end
end

it "remove_unlikely_candidates!" do
context "remove_unlikely_candidates!" do
doc = Readability::Document.new(simple_html_fixture)
doc.remove_unlikely_candidates!

Expand All @@ -185,7 +185,7 @@ describe Readability do
end
end

it "score_paragraphs" do
context "score_paragraphs" do
doc = Readability::Document.new(<<-HTML)
<html>
<head>
Expand Down Expand Up @@ -243,7 +243,7 @@ describe Readability do
end
end

it "the cant_read.html fixture" do
context "the cant_read.html fixture" do
it "should work on the cant_read.html fixture with some allowed tags" do
allowed_tags = %w[div span table tr td p i strong u h1 h2 h3 h4 pre code br a]
allowed_attributes = %w[href]
Expand All @@ -253,7 +253,7 @@ describe Readability do
end
end

it "general functionality" do
context "general functionality" do
options = Readability::Options.new(min_text_length: 0, retry_length: 1)
doc = Readability::Document.new("<html><head><title>title!</title></head><body><div><p>Some content</p></div></body>", options)

Expand All @@ -270,7 +270,7 @@ describe Readability do
end
end

it "ignoring sidebars" do
context "ignoring sidebars" do
options = Readability::Options.new(min_text_length: 0, retry_length: 1)
doc = Readability::Document.new("<html><head><title>title!</title></head><body><div><p>Some content</p></div><div class=\"sidebar\"><p>sidebar<p></div></body>",
options)
Expand All @@ -280,7 +280,7 @@ describe Readability do
end
end

it "inserting space for block elements" do
context "inserting space for block elements" do
html = <<-HTML
<html><head><title>title!</title></head>
<body>
Expand All @@ -298,7 +298,7 @@ describe Readability do
end
end

it "outputs good stuff for known documents" do
context "outputs good stuff for known documents" do
html_files = Dir.glob(File.dirname(__FILE__) + "/fixtures/samples/*.html")
samples = html_files.map { |filename| File.basename(filename, ".html") }

Expand Down Expand Up @@ -350,7 +350,7 @@ describe Readability do
end
end

it "#make_html" do
context "#make_html" do
it "should strip the html comments tag" do
doc = Readability::Document.new("<html><head><meta http-equiv=\"content-type\" content=\"text/html; charset=LATIN1\"></head><body><div>hi!<!-- bye~ --></div></body></html>")
content = doc.content
Expand All @@ -368,7 +368,7 @@ describe Readability do
end
end

it "No side-effects" do
context "No side-effects" do
bbc = File.read(File.dirname(__FILE__) + "/fixtures/bbc.html")
nytimes = File.read(File.dirname(__FILE__) + "/fixtures/nytimes.html")
thesum = File.read(File.dirname(__FILE__) + "/fixtures/thesun.html")
Expand Down Expand Up @@ -396,7 +396,7 @@ describe Readability do
end
end

it "Code blocks" do
context "Code blocks" do
code = File.read(File.dirname(__FILE__) + "/fixtures/code.html")
options = Readability::Options.new(tags: %w[div p img a ul ol li h1 h2 h3 h4 h5 h6 blockquote strong em b code pre],
attributes: %w[src href],
Expand All @@ -413,7 +413,7 @@ describe Readability do
end
end

it "remove all tags" do
context "remove all tags" do
options = Readability::Options.new(tags: [] of String)

it "should work for an incomplete piece of HTML" do
Expand All @@ -433,7 +433,7 @@ describe Readability do
end
end

it "boing boing" do
context "boing boing" do
boing_boing = File.read(File.dirname(__FILE__) + "/fixtures/boing_boing.html")

# crystal author: I don't understand this spec :/
Expand Down Expand Up @@ -465,7 +465,7 @@ describe Readability do
end
end

it "clean_conditionally_reason?" do
context "clean_conditionally_reason?" do
list_fixture = "<div><p>test</p>#{"<li></li>" * 102}"

it "does not raise error" do
Expand Down
8 changes: 0 additions & 8 deletions src/ext/attributes.cr
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/ext/libxml2.cr
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/readability.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# While waiting for https://github.com/crystal-lang/crystal/pull/6910 to hit master
require "./ext/*"
require "xml"
require "./readability/**"

module Readability
Expand Down