Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nautilus integration to 1.0 #119

Merged
merged 3 commits into from
May 29, 2024
Merged

Update nautilus integration to 1.0 #119

merged 3 commits into from
May 29, 2024

Conversation

johannesulf
Copy link
Contributor

This PR should update the nautilus sampler integration to version 1.0. Currently, cosmosis actually only supports nautilus version 0.6. What was the reason for not supporting 0.7? By the way, the updates in 0.7 and 1.0 are fairly minor. Still, it would be good to update cosmosis to nautilus 1.0.

@johannesulf
Copy link
Contributor Author

Looks like version 1.0.0 actually introduced a bug when handling blobs. That's what's causing the test failure. Cosmosis is handling blobs in a slightly unusual way that's currently not covered in any of my tests. I'll release a new version 1.0.1 soon and make sure that future versions of nautilus have tests for the way cosmosis handles blobs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.02%. Comparing base (1ef5157) to head (dbf6648).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   61.03%   61.02%   -0.01%     
==========================================
  Files         115      115              
  Lines       11915    11919       +4     
==========================================
+ Hits         7272     7274       +2     
- Misses       4643     4645       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannesulf
Copy link
Contributor Author

Looks good now. The two test failures are due to me updating the cosmosis branch too quickly after publishing nautilus 1.0.1. In these two cases, pip still installed the older version 1.0.0.

@joezuntz
Copy link
Owner

Sorry for the delay on this - I'm on paternity leave but will be back in June to review.

@joezuntz joezuntz merged commit 5f92934 into joezuntz:main May 29, 2024
10 checks passed
@joezuntz
Copy link
Owner

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants