Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -Event suffix in event type names #191

Closed
joffrey-bion opened this issue Aug 10, 2022 · 0 comments
Closed

Remove -Event suffix in event type names #191

joffrey-bion opened this issue Aug 10, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone
4.0.0

Comments

@joffrey-bion
Copy link
Owner

These events are already nested under a sealed class named <Domain>Event (for instance AnimationEvent for the Animation domain).

Therefore, when naming specific event types, it looks redundant: AnimationEvent.AnimationCreatedEvent. It would be better to drop the Event suffix: AnimationEvent.AnimationCreated
@joffrey-bion joffrey-bion added the enhancement New feature or request label Aug 10, 2022
joffrey-bion added a commit that referenced this issue Aug 11, 2022
@joffrey-bion
Remove -Event suffix
a7984ce 
Resolves:
#191
joffrey-bion added a commit that referenced this issue Aug 11, 2022
@joffrey-bion
Remove -Event suffix
5f77ee3 
Resolves:
#191
joffrey-bion added a commit that referenced this issue Aug 11, 2022
@joffrey-bion
Remove -Event suffix
e988785 
Resolves:
#191
joffrey-bion added a commit that referenced this issue Aug 15, 2022
@joffrey-bion
Remove -Event suffix
07b6dd3 
Resolves:
#191
joffrey-bion added a commit that referenced this issue Aug 16, 2022
@joffrey-bion
Remove -Event suffix
2775eec 
Resolves:
#191
joffrey-bion added a commit that referenced this issue Aug 16, 2022
@joffrey-bion
Remove -Event suffix
58f3529 
Resolves:
#191
@joffrey-bion joffrey-bion added this to the 4.0.0 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@joffrey-bion