Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event subscription flows hang if the target crashes #222

Closed
joffrey-bion opened this issue Mar 7, 2023 · 0 comments
Closed

Event subscription flows hang if the target crashes #222

joffrey-bion opened this issue Mar 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@joffrey-bion
Copy link
Owner

A Chrome target may crash at anytime for various reasons (e.g. resource exhaustion). We can get an InspectorEvent.targetCrashed in these cases even when events are not explicitly enabled for the InspectorDomain. We should fail every event flow immediately when getting such crash to prevent collectors from hanging indefinitely, as no more events will ever be received anyway.

@joffrey-bion joffrey-bion added the bug Something isn't working label Mar 7, 2023
joffrey-bion added a commit that referenced this issue Mar 7, 2023
joffrey-bion added a commit that referenced this issue Mar 7, 2023
joffrey-bion added a commit that referenced this issue Mar 7, 2023
joffrey-bion added a commit that referenced this issue Mar 7, 2023
joffrey-bion added a commit that referenced this issue Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant