Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awaitNodeBySelector can potentially throw IAE when cancelled #239

Closed
joffrey-bion opened this issue May 6, 2023 · 0 comments
Closed

awaitNodeBySelector can potentially throw IAE when cancelled #239

joffrey-bion opened this issue May 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@joffrey-bion
Copy link
Owner

This function uses a while(isActive) which can theoretically stop and leave the loop on cancellation, and throw IAE instead of CancellationException
@joffrey-bion joffrey-bion added the bug Something isn't working label May 6, 2023
joffrey-bion added a commit that referenced this issue May 7, 2023
@joffrey-bion
Fix awaitNodeBySelector so it doesn't trigger IAE on cancellation
ace83da 
Resolves:
#239
Resolves:
#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion