Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ChromePageSession -> PageSession #253

Closed
joffrey-bion opened this issue May 14, 2023 · 0 comments
Closed

Rename ChromePageSession -> PageSession #253

joffrey-bion opened this issue May 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@joffrey-bion
Copy link
Owner

joffrey-bion commented May 14, 2023 •
edited
Loading

This comes as a consequence of #252 because we now generate those interfaces, and some of them would have very long names with the Chrome prefix, which is admittedly unnecessary.
@joffrey-bion joffrey-bion added the enhancement New feature or request label May 14, 2023
@joffrey-bion joffrey-bion mentioned this issue May 14, 2023
Closed
joffrey-bion added a commit that referenced this issue May 15, 2023
@joffrey-bion
Allow to connect to any target type

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e457939 
Resolves:
#251
Resolves:
#252
Resolves:
#253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion